Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use matrix build for multi-platform Docker build #260

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Use matrix build for multi-platform Docker build #260

merged 8 commits into from
Jun 27, 2024

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented Jun 27, 2024 •
edited
Loading

This PR definitively fixes the multi-platform image generation, by using a matrix build.

Test plan

@keynmol keynmol marked this pull request as ready for review June 27, 2024 11:18
@keynmol keynmol changed the title Use matrix build for multi-platform Use matrix build for multi-platform Docker build Jun 27, 2024
@keynmol keynmol requested a review from kritzcreek June 27, 2024 11:18
kritzcreek
kritzcreek approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@kritzcreek kritzcreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yolo

@keynmol keynmol merged commit e3cf268 into main Jun 27, 2024
6 checks passed
@keynmol keynmol deleted the fix-docker-workflow branch June 27, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kritzcreek kritzcreek kritzcreek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keynmol @kritzcreek